Wire up ResourceMapper #960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Essentially, URLs ending with a '/' will internally be translated to paths such as 'index.html', 'index.ttl', ... depending on the content type
rubensworks
added
enhancement
semver-major
ghost
assigned
Closed
RubenVerborgh
approved these changes
Nov 22, 2018
lib/resource-mapper.js
Outdated
| // Find a file with the same name (minus the dollar extension) | ||
| const match = files.find(f => this._removeDollarExtension(f) === filename) | ||
| let match = files.find(f => this._removeDollarExtension(f) === filename || | ||
| (isIndex && f.startsWith(this._indexName + '.'))) |
Contributor
There was a problem hiding this comment.
Just wondering here if the first case and the isIndex case are mutually exclusive. If they are, we might want to write this differently.
Contributor
Author
There was a problem hiding this comment.
They are not, because for example space/index$.html might already be present, so we still should match with that file when needed.
Those files can not be created by solid, following the comment above. But I think it's good to at least be compatible with this case, should those files be created by another application.
| // Error if no match was found, | ||
| // unless the URL ends with a '/', | ||
| // in that case we fallback to the folder itself. | ||
| if (isIndex) { |
Contributor
There was a problem hiding this comment.
Given the above comment, we might want fully separate isIndex code paths.
Merged
Contributor
Author
|
Comments are resolved :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This replaces #959 because I started from a new branch with manual cherry-picking from the old one, instead of doing a highly conflicting rebase)
As requested in #662, this wires up the new ResourceMapper, as the next step for the big ResourceMapper refactor (#946).
A bunch of existing mapping-related issues popped up when working on this PR (see commits), and have also been fixed.