Skip to content

Conversation

@melvincarvalho
Copy link
Contributor

No description provided.

@dmitrizagidulin
Copy link
Contributor

@melvincarvalho - thank you for the PR! Can you tell us a bit more about what it's trying to fix?

@melvincarvalho
Copy link
Contributor Author

Consider the solid spec, when POSTing to an inbox.

Should something listening on the inbox be notified when a new resource is created?

From what I can tell. The dirname command will notify the parent directory. The basename will notify a string that is not a URI.

@dmitrizagidulin
Copy link
Contributor

👍 , thanks @melvincarvalho! Merging.

@dmitrizagidulin dmitrizagidulin merged commit 447b101 into nodeSolidServer:master Feb 8, 2017
@CxRes
Copy link

CxRes commented Mar 2, 2020

@melvincarvalho could you please explain the if statement in your change? AFAICT parent will never equal req.originalUrl?

var parent = path.dirname(req.originalUrl) + path.sep
if (parent !== req.originalUrl) {
  solidWs.publish(parent)
}

On the other hand you may want to check if you are at server root. Is that the intention?

@jaxoncreed
Copy link
Contributor

NSS will also need a PR to update it's dependency on on this.

@CxRes
Copy link

CxRes commented Mar 2, 2020

@jaxoncreed May I suggest that you use dependabot on solid repos...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants