Skip to content

Defect OpenId configuration issue #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
michielbdejong merged 3 commits into from
Aug 24, 2020
Merged

Defect OpenId configuration issue #24

michielbdejong merged 3 commits into from
Aug 24, 2020

Conversation

@jholleran
Copy link
Contributor

@jholleran jholleran commented Aug 23, 2020 •
edited
Loading

The keys property is getting returned and should be masked from the oidc configuration response.

acoburn
acoburn approved these changes Aug 23, 2020
View reviewed changes
Copy link

@acoburn acoburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

michielbdejong
michielbdejong approved these changes Aug 24, 2020
View reviewed changes
Copy link
Member

@michielbdejong michielbdejong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@michielbdejong michielbdejong merged commit 690a7fb into nodeSolidServer:master Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michielbdejong michielbdejong michielbdejong approved these changes

+1 more reviewer

@acoburn acoburn acoburn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jholleran @michielbdejong @acoburn