Add .nvmrc and node version checker

[bbogdanov]

No description provided.

[coveralls]

Coverage remained the same at 64.653% when pulling e45a318 on bbogdanov:master into 54a320d on solid:master.

[RubenVerborgh]

Thanks for proposing. I'm not convinced about having .nvmrc in the repository though, isn't this a developer-specific preference?

[RubenVerborgh]

Let's use const for imports.

[RubenVerborgh]

@bbogdanov Shall we just make the checker a hidden file and executable? Then it's all good to go.

[bbogdanov]

@bbogdanov Shall we just make the checker a hidden file and executable? Then it's all good to go.

@RubenVerborgh The file is now a dot file and executable.

[RubenVerborgh]

Thanks! is .nvmrc still missing a newline though?

[RubenVerborgh]

Thanks a lot!

[bbogdanov]

@RubenVerborgh I just realized the checker is running before the installation of the packages but the checker depends on one of the packages - semver. Travis seems is not using the post and pre-install scripts at the moment. Would you like me to set the script to run on postinstall? Or to make the script npm install semver && node .check-engines-requirements? I think the first approach is a better one.

[RubenVerborgh]

Ooh yes first approach please. I'll just fix it myself in master.

[RubenVerborgh]

Caught it in cf7d5ce, thanks.

[bbogdanov]

Great, you are welcome!

[RubenVerborgh]

The engine check caused problems when installing the package, since the script was being run on postinstall. Rather than tweaking this, I removed the script in 663e28f. (Have not seen other repositories use it.)

[bbogdanov]

Could you give me more information about them/it?

[RubenVerborgh]

So when running npm install in a repository that has solid-auth-client as one of its dependencies, the following problems would occur:

• the script would not be found
• semver would not be installed (because it is a devDependency)

These issues broke the release of solid-auth-client 2.2.7, which had to be retracted.

While they might be fixable (in multiple ways), I think the fragility is bigger than the utility.

[bbogdanov]

I didn't have this in mind. You are right, these problems could occur. Thank you for letting me know!