Skip to content

Conversation

@michaelsproul
Copy link
Contributor

Previously when deleting the example rectangle node from a new document, there'd be a null pointer error.

[java] java.lang.NullPointerException
[java]  at nodebox.client.NodeBoxDocument.checkValidPort(Unknown Source)
[java]  at nodebox.client.NodeBoxDocument.getValue(Unknown Source)
[java]  at nodebox.handle.AbstractHandle.getValue(Unknown Source)
[java]  at nodebox.handle.FourPointHandle.draw(Unknown Source)
[java]  at nodebox.client.Viewer.paintHandle(Unknown Source)
[java]  at nodebox.client.Viewer.paintComponent(Unknown Source)
[java]  at javax.swing.JComponent.paint(JComponent.java:1045)
[java]  at javax.swing.JComponent.paintChildren(JComponent.java:878)
[java]  at javax.swing.JComponent.paint(JComponent.java:1054)
[java]  at javax.swing.JComponent.paintToOffscreen(JComponent.java:5210)
[java]  at javax.swing.BufferStrategyPaintManager.paint(BufferStrategyPaintManager.java:295)
[java]  at javax.swing.RepaintManager.paint(RepaintManager.java:1249)
[java]  at javax.swing.JComponent._paintImmediately(JComponent.java:5158)
[java]  at javax.swing.JComponent.paintImmediately(JComponent.java:4969)
[java]  at javax.swing.RepaintManager$3.run(RepaintManager.java:808)
[java]  at javax.swing.RepaintManager$3.run(RepaintManager.java:796)
[java]  at java.security.AccessController.doPrivileged(Native Method)
[java]  at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:76)
[java]  at javax.swing.RepaintManager.paintDirtyRegions(RepaintManager.java:796)
[java]  at javax.swing.RepaintManager.paintDirtyRegions(RepaintManager.java:769)
[java]  at javax.swing.RepaintManager.prePaintDirtyRegions(RepaintManager.java:718)
[java]  at javax.swing.RepaintManager.access$1100(RepaintManager.java:62)
[java]  at javax.swing.RepaintManager$ProcessingRunnable.run(RepaintManager.java:1677)
[java]  at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:312)
[java]  at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:733)
[java]  at java.awt.EventQueue.access$200(EventQueue.java:103)
[java]  at java.awt.EventQueue$3.run(EventQueue.java:694)
[java]  at java.awt.EventQueue$3.run(EventQueue.java:692)
[java]  at java.security.AccessController.doPrivileged(Native Method)
[java]  at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:76)
[java]  at java.awt.EventQueue.dispatchEvent(EventQueue.java:703)
[java]  at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:242)
[java]  at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:161)
[java]  at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:150)
[java]  at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:146)
[java]  at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:138)
[java]  at java.awt.EventDispatchThread.run(EventDispatchThread.java:91)

I've added some checks to prevent this, in what I think is the best place...

fdb added a commit that referenced this pull request Jul 1, 2014
Prevent null pointer exception when deleting the first node.
@fdb fdb merged commit 849e7b4 into nodebox:master Jul 1, 2014
@fdb
Copy link
Member

fdb commented Jul 1, 2014

Thanks for your contribution!

@michaelsproul
Copy link
Contributor Author

No probs! Thanks for the awesome program! :)

@michaelsproul michaelsproul deleted the null-node-deletion branch July 1, 2014 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants