Fixes getAllNodeAddons matches non '.node' suffix files#159
Merged
a7ul merged 1 commit intonodegui:masterfrom Oct 3, 2021
Merged
Fixes getAllNodeAddons matches non '.node' suffix files#159a7ul merged 1 commit intonodegui:masterfrom
a7ul merged 1 commit intonodegui:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regular expressions in function
getAllNodeAddonsmay lead other files containing 'node' to be regarded as node addon, which can leads failure while packing.On Windows, I've encountered the problem that it passes some JavaScript file generated by webpack whose name contains 'node' to windeployqt, and fails to pack the whole application.
I have fixed this bug in this commit.