Skip to content

Support code signing macOS app bundle#40

Merged
a7ul merged 1 commit intonodegui:masterfrom
tadaskay:macdeployqt-codesign
Feb 25, 2020
Merged

Support code signing macOS app bundle#40
a7ul merged 1 commit intonodegui:masterfrom
tadaskay:macdeployqt-codesign

Conversation

@tadaskay
Copy link
Copy Markdown
Contributor

I couldn't run the packed apps on macOS Catalina (10.15.3) unless they were signed, providing the -codesign flag to macdeployqt. This allows specifying the identity for signing with an optional -s / --sign <identity> CLI flag.

@tadaskay tadaskay requested a review from a7ul February 24, 2020 11:41
@a7ul
Copy link
Copy Markdown
Collaborator

a7ul commented Feb 24, 2020

Brilliant!! Could you also add this to the README ?

Thanks a lot for this pr @tadaskay

@tadaskay
Copy link
Copy Markdown
Contributor Author

👍🏾
I've described it in README. Feel free to adjust the wording - I wasn't sure how you want to structure it.

@a7ul a7ul merged commit a5ec187 into nodegui:master Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants