This repository was archived by the owner on Aug 9, 2021. It is now read-only.
Fix cache download rename not awaiting#9
Merged
a7ul merged 1 commit intonodegui:masterfrom Sep 30, 2019
Merged
Conversation
Collaborator
|
Thanks @markrocket for the fix |
Collaborator
|
This will be released in the next qode update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes Issue #89 in the nodegui repo (
I have to run npm install twice on MacOS 10.14.4).The issue was that the qode install does not wait for the rename of a download to finish before checking if the download exists. Running the install again works because the file is already there.
This fix adds
awaitto the file rename.