fix regression in calling nodejitsu apis from behing a proxy#1
Merged
Marak merged 1 commit intonodejitsu:masterfrom Nov 10, 2011
tjanczuk:master
Merged
fix regression in calling nodejitsu apis from behing a proxy#1Marak merged 1 commit intonodejitsu:masterfrom tjanczuk:master
Marak merged 1 commit intonodejitsu:masterfrom
tjanczuk:master
Conversation
Marak
added a commit
that referenced
this pull request
Nov 10, 2011
[fix] regression in calling nodejitsu apis from behing a proxy
Contributor
|
Merged! Looks like we missed one, sorry about that! We'll be pushing out a new jitsu version today ( among with a few other changes ). Thank you very much! |
Marak
added a commit
that referenced
this pull request
Nov 10, 2011
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears one cannot call nodejitsu APIs from behind a proxy.
I installed jitsu toolset via
npm install jitsu -g. After reading nodejitsu/jitsu#106 I configured my proxy server with a call tonpm config set proxy http://<myproxyserver>:<myproxyserverport>. Despite that,jitsu signupwas unable to connect to the nodejitsu host.I believe the issue is with line https://github.com/nodejitsu/nodejitsu-api/blob/master/node.js/lib/client/client.js#L48 which should be
proxy = this.options.get('proxy');instead of current
proxy = this.proxy;(I verified this change fixes the problem).
The original pull request for issue nodejitsu/jitsu#106 that was merged in fixed the problem correctly, but the fix was subsequently overwritten by f96f735.