Conversation
[minor] Added missing keywords
[minor] Using strict mode in the module now, it caught some small pitfalls [minor] Small optimazations to the createClient, no pointless event listeners are added [minor] Removed pointless require statements and made the code style more uniform. The reason for this refactor is that we need to support different remoteApi's for the applications as they can be hosted in different data centers.
[minor] Removed the `res.statusCode` code smell Applications that are hosted in different datacenters need to be called at their correct endpoint. The cloud details are inside of the app documents so we need to fetch both the endpoint resource and the app document before we know which datacenter we need to hit for the given change. The statusCode was introduced in commit 9cea327 but Avian has no memory of why he did it. So i'm removing it to prevent possible breakage when you expect that the result is always an object.
… `request` method. [refactor] Make the `upload` method use the `request` API instead of duplicating code.
Because multiple routes are affected by these changes.
…ration incase of failure [minor] Make some routes cloud compatible
[fix] removed a pointless cloud call
[fix] Added missing callback
…rototype.endpoints` to `Client.prototype.endpoints`
…respond with an unwrapped result.
Member
|
@indexzero did a All tests pass and it's merge-able so it should be good to go. FYI: I did a force push to rewrite the history of it. |
Member
Author
|
@3rd-Eden Looks good. Will bump this as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Big things on the near horizon.