Remove unused requires and Winston calls.#4
Merged
pksunkara merged 1 commit intonodejitsu:masterfrom Dec 17, 2011
coderarity:master
Merged
Remove unused requires and Winston calls.#4pksunkara merged 1 commit intonodejitsu:masterfrom coderarity:master
pksunkara merged 1 commit intonodejitsu:masterfrom
coderarity:master
Conversation
pksunkara
added a commit
that referenced
this pull request
Dec 17, 2011
Remove unused requires and Winston calls.
Contributor
|
Added the winston logging in nodejitsu/jitsu@d2133fc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed requires and calls to things outside of Node.js. The documentation only states that Node.js is required to use nodejitsu-api and that is the way it should be. I suggest taking the Winston calls that I removed here (in snapshot.js) and putting them into the jitsu repository, to prevent any lost functionality.