Add finalize cb to external arraybuffer (V8)#110
Merged
jasongin merged 1 commit intonodejs:api-prototype-8.xfrom Feb 23, 2017
Merged
Add finalize cb to external arraybuffer (V8)#110jasongin merged 1 commit intonodejs:api-prototype-8.xfrom
jasongin merged 1 commit intonodejs:api-prototype-8.xfrom
Conversation
Closed
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
jasongin
added a commit
that referenced
this pull request
Feb 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should support a finalize callback wherever an external data pointer is provided. This was an oversight in my TypedArray implementation.
I've also added a test case for the
napi_create_external_arraybufferAPI, though it doesn't use the finalize callback because it would be difficult to force the finalizer to be invoked during the test.