Skip to content

chore(lint): report error on invalid change versions, except REPLACEME #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ovflowd merged 3 commits into from
Mar 28, 2025
Merged

chore(lint): report error on invalid change versions, except REPLACEME #238

ovflowd merged 3 commits into from
Mar 28, 2025

Conversation

@avivkeller
Copy link
Member

@avivkeller avivkeller commented Mar 24, 2025

Per nodejs/node#57343 (review)

  • We should not report REPLACEME as an invalid version.
  • We should report invalid versions as a hard failure.

@avivkeller avivkeller requested a review from a team as a code owner March 24, 2025 22:46
@avivkeller avivkeller mentioned this pull request Mar 24, 2025
Merged
aduh95
aduh95 reviewed Mar 25, 2025
View reviewed changes
aduh95
aduh95 reviewed Mar 25, 2025
View reviewed changes
@avivkeller
Copy link
Member Author

avivkeller commented Mar 25, 2025

I've updated this with support for NODE_RELEASED_VERSIONS.

@avivkeller avivkeller requested a review from aduh95 March 25, 2025 17:18
aduh95
aduh95 reviewed Mar 25, 2025
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ovflowd
ovflowd approved these changes Mar 28, 2025
View reviewed changes
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ovflowd ovflowd merged commit 9be11fd into main Mar 28, 2025
7 checks passed
@ovflowd ovflowd deleted the fix/replaceme branch March 28, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 left review comments

@ovflowd ovflowd ovflowd approved these changes

@araujogui araujogui araujogui approved these changes

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@avivkeller @ovflowd @aduh95 @araujogui @AugustinMauroy