Skip to content

doc: initial governance#19

Merged
MylesBorins merged 2 commits into
openjs-foundation:masterfrom
MylesBorins:basic-governance
Nov 7, 2018
Merged

doc: initial governance#19
MylesBorins merged 2 commits into
openjs-foundation:masterfrom
MylesBorins:basic-governance

Conversation

@MylesBorins

Copy link
Copy Markdown
Contributor

This documents the governance as discussed in the 2018-10-22 team meeting

Refs: #2

Comment thread GOVERNANCE.md
consensus.

If an agenda item cannot reach a consensus, a Team member can call for
the item to be decided by a vote or to table the issue to the next

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was discussed in the meeting that there will not be any "votes"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Comment thread GOVERNANCE.md Outdated

If an agenda item cannot reach a consensus, a Team member can call for
to table the issue to the next meeting. The decision must be seconded by
a majority of the Team or else the discussion will continue.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see a provision in here that if there are multiple choices on the table and consensus cannot be reached on one over the other, both choices are documented along with the discussion around it. This will allow us to keep iterating without blocking on any single issue.

Comment thread GOVERNANCE.md Outdated
Pull requests must have no objections and have been open for at least 72 hours
in order to be merged into this repository. A pull request that is is unable to
reach consensus cannot be merged into this repository.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A simplified staged proposal process as suggested by Jory would be ideal here.

  • Stage 0 - New Proposal
  • Stage 1 - Accepted Proposal ("Accepted" in the sense that the committee has agreed to take it on)
  • Stage 2 - Incorporated Proposal (Incorporated into the recommendations being made by this proposal)

As per my previous comment, if there are competing proposals that we cannot get a clear consensus on, a combined proposal that includes discussion of both should be what makes it to Stage 2.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you like to push a commit to incorporate these changes and I can iterate?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be unable to do so until at least this afternoon or tomorrow

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sendilkumarn sendilkumarn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit

Comment thread GOVERNANCE.md Outdated
It only applies to [the bootstrap repository](https://github.com/nodejs/bootstrap).

Pull requests must have no objections and have been open for at least 72 hours
in order to be merged into this repository. A pull request that is is unable to

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: is is repeated

@MylesBorins MylesBorins force-pushed the basic-governance branch 2 times, most recently from 433c1ca to c06ffe4 Compare October 29, 2018 18:33
@MylesBorins

Copy link
Copy Markdown
Contributor Author

updated this doc to be a Stage 0 proposal. Any objections to landing as is and iterating?

@sendilkumarn sendilkumarn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This documents the governance as discussed in the 2018-10-22 team meeting

Refs: openjs-foundation#2
@MylesBorins

Copy link
Copy Markdown
Contributor Author

Going to hold off on landing this until our process has been fleshed out. I feel comfortable calling this stage zero right now. I would like to move it to stage 1 or stage 2 in the next meeting

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. I would move the DCO to CONTRIBUTING.md right now.


The intention of the agenda is not to approve or review all patches;
that should happen continuously on GitHub and be handled by the larger
group of Collaborators.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not use the term patches here, maybe documents?

@sendilkumarn sendilkumarn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins

Copy link
Copy Markdown
Contributor Author

landing as agreed in the last meeting. We may need to refactor the proposal layout based on future PRs

@MylesBorins MylesBorins merged commit 79b403c into openjs-foundation:master Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants