AIX libuv build fails with "Member libiconv.so.2 is not found in archive"

[richardlau]

https://ci.nodejs.org/view/libuv/job/libuv-test-commit-aix-cmake/301/nodes=aix71-ppc64/console

    Building C object CMakeFiles/cmTC_2220e.dir/testCCompiler.c.o
    /opt/freeware/bin/gcc    -o CMakeFiles/cmTC_2220e.dir/testCCompiler.c.o   -c /home/iojs/build/workspace/libuv-test-commit-aix-cmake/nodes/aix71-ppc64/out/cmake/CMakeFiles/CMakeTmp/testCCompiler.c
    Could not load program /opt/freeware/bin/gcc:
    	Dependent module /usr/lib/libiconv.a(libiconv.so.2) could not be loaded.
    	Member libiconv.so.2 is not found in archive 
    gmake[1]: *** [CMakeFiles/cmTC_2220e.dir/build.make:66: CMakeFiles/cmTC_2220e.dir/testCCompiler.c.o] Error 255
    gmake[1]: Leaving directory '/home/iojs/build/workspace/libuv-test-commit-aix-cmake/nodes/aix71-ppc64/out/cmake/CMakeFiles/CMakeTmp'
    gmake: *** [Makefile:121: cmTC_2220e/fast] Error 2

Most probably related to running the ansible playbook against the AIX hosts yesterday (#2531 (comment)).

[richardlau]

node-test-commit-aix builds are passing.

citgm-smoker is failing:
e.g. https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2611/nodes=aix71-ppc64/testReport/junit/(root)/citgm/bufferutil_v4_0_3/

 gmake: Entering directory '/home/iojs/tmp/citgm_tmp/a5b373ee-2e18-4683-9af5-0ba24d1c83a3/bufferutil/build'
   CC(target) Release/obj.target/bufferutil/src/bufferutil.o
 gmake: Leaving directory '/home/iojs/tmp/citgm_tmp/a5b373ee-2e18-4683-9af5-0ba24d1c83a3/bufferutil/build'
 (node:19005650) [DEP0150] DeprecationWarning: Setting process.config is deprecated. In the future the property will be read-only.
 (Use `node --trace-deprecation ...` to show where the warning was created)
 Could not load program /opt/freeware/bin/gcc:
 	Dependent module /usr/lib/libiconv.a(libiconv.so.2) could not be loaded.
 	Member libiconv.so.2 is not found in archive 
 gmake: *** [bufferutil.target.mk:114: Release/obj.target/bufferutil/src/bufferutil.o] Error 255

[richardlau]

In https://github.com/nodejs/build/blob/master/ansible/MANUAL_STEPS.md#fix-missing-shared-objects we have instructions to manually do:

sudo rm /usr/lib/libiconv.a && sudo ln -s /opt/freeware/lib/libiconv.a /usr/lib

I'm not convinced we need to do this anymore.

If I login to e.g. test-ibm-aix71-ppc64_be-4 I can run gcc/gcc-6/gcc-8:

bash-5.0# /opt/freeware/bin/gcc --version
gcc (GCC) 8.3.0
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

bash-5.0# /opt/freeware/bin/gcc-6 --version
gcc-6 (GCC) 6.3.0
Copyright (C) 2016 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

bash-5.0# /opt/freeware/bin/gcc-8 --version
gcc-8 (GCC) 8.3.0
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

bash-5.0# echo $LIBPATH

bash-5.0#

However when run via Jenkins we end up with a LIBPATH of /opt/jdk8u282-b08-jre/lib/ppc64/j9vm:/opt/jdk8u282-b08-jre/lib/ppc64:/opt/jdk8u282-b08-jre/lib/ppc64/jli:/opt/jdk8u282-b08-jre/../lib/ppc64:/usr/lib (https://ci.nodejs.org/job/libuv-test-commit-aix-cmake/301/nodes=aix71-ppc64/injectedEnvVars/). I suspect given the entries pointing to the JDK that the LIBPATH is either being set by Jenkins or the JDK itself.

If I run the same as above but with a LIBPATH set to /usr/lib:

bash-5.0# LIBPATH=/usr/lib /opt/freeware/bin/gcc --version
Could not load program /opt/freeware/bin/gcc:
        Dependent module /usr/lib/libiconv.a(libiconv.so.2) could not be loaded.
        Member libiconv.so.2 is not found in archive
bash-5.0# LIBPATH=/usr/lib /opt/freeware/bin/gcc-6 --version
gcc-6 (GCC) 6.3.0
Copyright (C) 2016 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

bash-5.0# LIBPATH=/usr/lib /opt/freeware/bin/gcc-8 --version
Could not load program /opt/freeware/bin/gcc-8:
        Dependent module /usr/lib/libiconv.a(libiconv.so.2) could not be loaded.
        Member libiconv.so.2 is not found in archive
bash-5.0#

node-test-commit-aix passes because it explicitly unsets LIBPATH:

# LIBPATH must be set to /opt/freeware/lib for the git plugin to work, however
# it must be unset for the build.  The ansible start script sets the libpath
# so that when git runs its set, but we must unset it here otherwise it
# causes the build to find the 32 bit stdc++ library instead of the 64 bit one
# that we need when running binaries (like mksnapshot) since our target is 64 bit
unset LIBPATH
echo LIBPATH:$LIBPATH

AFAICT we no longer set LIBPATH in https://github.com/nodejs/build/blob/master/ansible/roles/jenkins-worker/templates/aix.rc2.j2.

I'm going to modify the CITGM and libuv jobs so they explicitly unset LIBPATH on AIX.

[richardlau]

Test builds:
https://ci.nodejs.org/view/libuv/job/libuv-test-commit-aix-cmake/302/ passed.
https://ci.nodejs.org/view/libuv/job/libuv-test-commit-aix/2112/ passed.
https://ci.nodejs.org/job/citgm-smoker/nodes=aix71-ppc64/2615/ in progress.
https://ci.nodejs.org/job/citgm-smoker/nodes=aix71-ppc64/2616/ fixed the native addons modules.

[richardlau]

I've opened #2535 to consistently unset LIBPATH in the select-compiler.sh script on AIX.

[richardlau]

Fixed by #2535.