V8 CI broken on IBM platforms

[targos]

See https://ci.nodejs.org/job/node-test-commit-v8-linux/6838/nodes=rhel8-ppc64le,v8test=v8test/ and https://ci.nodejs.org/job/node-test-commit-v8-linux/6838/nodes=rhel8-s390x,v8test=v8test/

Looks like something happened between Nov 3 and Nov 4: https://ci.nodejs.org/job/node-test-commit-v8-linux/

@nodejs/platform-ppc @nodejs/platform-s390

[miladfarca]

Could be related o these two changes to host_arch:
https://chromium-review.googlesource.com/c/v8/v8/+/7102361
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7100932
ppc is renamed to ppc64 and s390 to s390x.

[targos]

Errors for s390x look like that:

09:09:53 Errors:
09:09:53   failed to resolve gn/gn/linux-s390x@git_revision:07d3c6f4dc290fae5ca6152ebcb37d6815c411ab (line 5): no such package: gn/gn/linux-s390x
09:09:53   failed to resolve infra/rbe/client/linux-s390x@re_client_version:0.185.0.db415f21-gomaip (line 8): no such package: infra/rbe/client/linux-s390x
09:09:53   failed to resolve infra/3pp/tools/ninja/linux-s390x@version:3@1.12.1.chromium.4 (line 11): no such package: infra/3pp/tools/ninja/linux-s390x
09:09:53   failed to resolve build/siso/linux-s390x@git_revision:0915813c4c786240e12d03aa3018c02bab4df14f (line 14): no such package: build/siso/linux-s390x
09:09:53 Error: Command 'cipd ensure -log-level error -root . -ensure-file /tmp/tmpbynt2otr.ensure' returned non-zero exit status 1
09:09:53 Errors:
09:09:53   failed to resolve gn/gn/linux-s390x@git_revision:07d3c6f4dc290fae5ca6152ebcb37d6815c411ab (line 5): no such package: gn/gn/linux-s390x
09:09:53   failed to resolve infra/rbe/client/linux-s390x@re_client_version:0.185.0.db415f21-gomaip (line 8): no such package: infra/rbe/client/linux-s390x
09:09:53   failed to resolve infra/3pp/tools/ninja/linux-s390x@version:3@1.12.1.chromium.4 (line 11): no such package: infra/3pp/tools/ninja/linux-s390x
09:09:53   failed to resolve build/siso/linux-s390x@git_revision:0915813c4c786240e12d03aa3018c02bab4df14f (line 14): no such package: build/siso/linux-s390x

[miladfarca]

Yes conditions under DEPS (i.e https://github.com/v8/v8/blob/42f5ff65d12f0ef9294fa7d3875feba938a81904/DEPS#L148) are now matching against s390x and not s390. If your host_cpu is still set as s390 the download will happen and will fail.

[targos]

I don't know what to do. I see only s390x in the logs, never s390.

We have:

• 09:08:54 + make -j 4 test-v8 V=1 DESTCPU=s390x ARCH=s390x.release
• tools/make-v8.sh s390x.release
• BUILD_ARCH_TYPE=s390x.release

[miladfarca]

host_cpu is set by depot_tools, see this change which is now returning ppc64 and s390x:
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7100932

If you also use depot_tools make sure it's the latest version.

[richardlau]

I believe the issue is that we are using the latest version of depot_tools, which now return e.g. s390x instead of s390, but the version of V8 in deps/v8 on main and other branches in the Node.js source tree is older so DEPS are still matching against s390 and ppc, e.g. https://github.com/nodejs/node/blob/60b9aaa3a95f48dc7a10e5bfbec4071fe04048cd/deps/v8/DEPS#L144.

I think our options are either to:

• Modify tools/v8/node_common.py to checkout depot_tools at the commit hash that is in DEPS (this assumes we don't need to pick up any changes from later versions of depot_tools to build the older V8 versions).
• Backport v8/v8@2e4c5cf.

Whatever we do we are probably going to need to apply to every currently supported Node.js release line (i.e. main, v25.x-staging, v24.x-staging, v22.x-staging and v20.x-staging).

[targos]

The backport route seems simpler.

[targos]

nodejs/node#60654

[miladfarca]

Thank you both, let me know if I can help with the backports.