Skip to content

deps: V8: backport 2e4c5cf9b112 #60654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2025
Merged

deps: V8: backport 2e4c5cf9b112 #60654

merged 1 commit into from
Nov 11, 2025
+5 −5

Conversation

@targos
Copy link
Member

@targos targos commented Nov 9, 2025

Original commit message:

remove ppc and s390 from the host_arch list

We only support ppc64 and s390x.
Same changes is applied to depot_tools:
http://crrev.com/c/7100932

Change-Id: I1e4b660a1e46d1c609189301e8fd977fb7434748
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7102361
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Milad Farazmand <mfarazma@ibm.com>
Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103488}

Refs: v8/v8@2e4c5cf
Fixes: nodejs/build#4184
Co-authored-by: Michaël Zasso targos@protonmail.com

@miladfarca @targos
deps: V8: backport 2e4c5cf9b112
4237f43 
Original commit message:

    remove ppc and s390 from the host_arch list

    We only support ppc64 and s390x.
    Same changes is applied to depot_tools:
    http://crrev.com/c/7100932

    Change-Id: I1e4b660a1e46d1c609189301e8fd977fb7434748
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7102361
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: Milad Farazmand <mfarazma@ibm.com>
    Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#103488}

Refs: v8/v8@2e4c5cf
Fixes: nodejs/build#4184
Co-authored-by: Michaël Zasso <targos@protonmail.com>
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 9, 2025

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Nov 9, 2025
@targos targos mentioned this pull request Nov 9, 2025
Closed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 9, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6842/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 9, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6842/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 9, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6842/

@richardlau richardlau added lts-watch-v20.x PRs that may need to be released in v20.x lts-watch-v22.x PRs that may need to be released in v22.x lts-watch-v24.x PRs that may need to be released in v24.x labels Nov 9, 2025
@richardlau
Copy link
Member

richardlau commented Nov 9, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6842/

@miladfarca Have we seen this failure before on ppc64le?

14:19:21 === mjsunit/compiler/conditional-chain ===
14:19:21 --- stdout ---
14:19:21 test/mjsunit/mjsunit.js:418: Failure: expected <2510010000> found <-1784957296>
14:19:21 
14:19:21 Stack: MjsUnitAssertionError
14:19:21     at assertEquals test/mjsunit/mjsunit.js 513:7
14:19:21     at              test/mjsunit/compiler/conditional-chain.js 96:5
14:19:21     at              test/mjsunit/compiler/conditional-chain.js 123:3
14:19:21     throw new MjsUnitAssertionError(
14:19:21     ^
14:19:21 MjsUnitAssertionError
14:19:21     at assertEquals test/mjsunit/mjsunit.js 513:7
14:19:21     at              test/mjsunit/compiler/conditional-chain.js 96:5
14:19:21     at              test/mjsunit/compiler/conditional-chain.js 123:3
14:19:21 Command: out.gn/ppc64.release/d8 --test test/mjsunit/mjsunit.js test/mjsunit/compiler/conditional-chain.js --random-seed=-333550897 --nohard-abort --testing-d8-test-runner
14:19:21 
14:19:21 ===
14:19:21 === 1 tests failed
14:19:21 ===

@miladfarca
Copy link

miladfarca commented Nov 9, 2025

@richardlau Yes that's an intermittent failure due to a maglev bug, this fixes it:
https://chromium-review.googlesource.com/c/v8/v8/+/7063203

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 9, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6843/

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 9, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 9, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 9, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70118/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 9, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6844/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 9, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6844/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 9, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6844/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 10, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70126/

@targos targos added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 10, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 11, 2025
@nodejs-github-bot nodejs-github-bot merged commit 96f7a2b into nodejs:main Nov 11, 2025
93 of 95 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 11, 2025

Landed in 96f7a2b

targos added a commit to targos/node that referenced this pull request Nov 12, 2025
@targos
deps: V8: backport 2e4c5cf9b112
a711e2d 
Original commit message:

    remove ppc and s390 from the host_arch list

    We only support ppc64 and s390x.
    Same changes is applied to depot_tools:
    http://crrev.com/c/7100932

    Change-Id: I1e4b660a1e46d1c609189301e8fd977fb7434748
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7102361
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: Milad Farazmand <mfarazma@ibm.com>
    Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#103488}

Refs: v8/v8@2e4c5cf
Fixes: nodejs/build#4184
Co-authored-by: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs#60654
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
richardlau pushed a commit that referenced this pull request Nov 13, 2025
@targos @richardlau
deps: V8: backport 2e4c5cf9b112
e65b930 
Original commit message:

    remove ppc and s390 from the host_arch list

    We only support ppc64 and s390x.
    Same changes is applied to depot_tools:
    http://crrev.com/c/7100932

    Change-Id: I1e4b660a1e46d1c609189301e8fd977fb7434748
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7102361
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: Milad Farazmand <mfarazma@ibm.com>
    Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#103488}

Refs: v8/v8@2e4c5cf
Fixes: nodejs/build#4184
Co-authored-by: Michaël Zasso <targos@protonmail.com>
PR-URL: #60654
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
richardlau pushed a commit that referenced this pull request Nov 13, 2025
@targos @richardlau
deps: V8: backport 2e4c5cf9b112
08eb637 
Original commit message:

    remove ppc and s390 from the host_arch list

    We only support ppc64 and s390x.
    Same changes is applied to depot_tools:
    http://crrev.com/c/7100932

    Change-Id: I1e4b660a1e46d1c609189301e8fd977fb7434748
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7102361
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: Milad Farazmand <mfarazma@ibm.com>
    Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#103488}

Refs: v8/v8@2e4c5cf
Fixes: nodejs/build#4184
Co-authored-by: Michaël Zasso <targos@protonmail.com>
PR-URL: #60654
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
richardlau pushed a commit that referenced this pull request Nov 13, 2025
@targos @richardlau
deps: V8: backport 2e4c5cf9b112
f8d8c1b 
Original commit message:

    remove ppc and s390 from the host_arch list

    We only support ppc64 and s390x.
    Same changes is applied to depot_tools:
    http://crrev.com/c/7100932

    Change-Id: I1e4b660a1e46d1c609189301e8fd977fb7434748
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7102361
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: Milad Farazmand <mfarazma@ibm.com>
    Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#103488}

Refs: v8/v8@2e4c5cf
Fixes: nodejs/build#4184
Co-authored-by: Michaël Zasso <targos@protonmail.com>
PR-URL: #60654
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
@richardlau richardlau added backported-to-v20.x PRs backported to the v20.x-staging branch. backported-to-v22.x PRs backported to the v22.x-staging branch. backported-to-v24.x PRs backported to the v24.x-staging branch. and removed lts-watch-v20.x PRs that may need to be released in v20.x lts-watch-v22.x PRs that may need to be released in v22.x lts-watch-v24.x PRs that may need to be released in v24.x labels Nov 13, 2025
@targos targos deleted the fix-v8-ci branch November 13, 2025 12:44
targos added a commit that referenced this pull request Nov 13, 2025
@targos
deps: V8: backport 2e4c5cf9b112
6494c7b 
Original commit message:

    remove ppc and s390 from the host_arch list

    We only support ppc64 and s390x.
    Same changes is applied to depot_tools:
    http://crrev.com/c/7100932

    Change-Id: I1e4b660a1e46d1c609189301e8fd977fb7434748
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7102361
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: Milad Farazmand <mfarazma@ibm.com>
    Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#103488}

Refs: v8/v8@2e4c5cf
Fixes: nodejs/build#4184
Co-authored-by: Michaël Zasso <targos@protonmail.com>
PR-URL: #60654
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Nov 13, 2025
@targos @aduh95
deps: V8: backport 2e4c5cf9b112
3cac85b 
Original commit message:

    remove ppc and s390 from the host_arch list

    We only support ppc64 and s390x.
    Same changes is applied to depot_tools:
    http://crrev.com/c/7100932

    Change-Id: I1e4b660a1e46d1c609189301e8fd977fb7434748
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7102361
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: Milad Farazmand <mfarazma@ibm.com>
    Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#103488}

Refs: v8/v8@2e4c5cf
Fixes: nodejs/build#4184
Co-authored-by: Michaël Zasso <targos@protonmail.com>
PR-URL: #60654
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
richardlau pushed a commit that referenced this pull request Nov 14, 2025
@targos @richardlau
deps: V8: backport 2e4c5cf9b112
5316b58 
Original commit message:

    remove ppc and s390 from the host_arch list

    We only support ppc64 and s390x.
    Same changes is applied to depot_tools:
    http://crrev.com/c/7100932

    Change-Id: I1e4b660a1e46d1c609189301e8fd977fb7434748
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7102361
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: Milad Farazmand <mfarazma@ibm.com>
    Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#103488}

Refs: v8/v8@2e4c5cf
Fixes: nodejs/build#4184
Co-authored-by: Michaël Zasso <targos@protonmail.com>
PR-URL: #60654
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
@github-actions github-actions bot mentioned this pull request Nov 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@richardlau richardlau richardlau approved these changes

@sxa sxa sxa approved these changes

@juanarbol juanarbol juanarbol approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backported-to-v20.x PRs backported to the v20.x-staging branch. backported-to-v22.x PRs backported to the v22.x-staging branch. backported-to-v24.x PRs backported to the v24.x-staging branch. build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

V8 CI broken on IBM platforms

9 participants

@targos @nodejs-github-bot @richardlau @miladfarca @cjihrig @joyeecheung @sxa @juanarbol @RafaelGSS