Add requirement that non-collaborator members be approved by the TSC#3956
Merged
Add requirement that non-collaborator members be approved by the TSC#3956
Conversation
To avoid XY-style attacks, build-wg members should be highly trusted. Therefore, if they are not already Node.js collaborators, they should be approved by the TSC.
MoLow
approved these changes
Nov 11, 2024
anonrig
approved these changes
Nov 11, 2024
BridgeAR
reviewed
Nov 11, 2024
Member
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
LGTM
The numbering just seems to have changed unintentionally.
UlisesGascon
approved these changes
Nov 11, 2024
Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
Member
|
@mcollina does this requirement already exist for the release WG? |
Member
Author
|
yes it does |
sxa
approved these changes
Nov 17, 2024
richardlau
approved these changes
Nov 18, 2024
Member
|
@targos any concerns with this? |
targos
approved these changes
Nov 21, 2024
Member
|
I think this has been open long enough and we have a number of +1s so landing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid XY-style attacks, build-wg members should be highly trusted. Therefore, if they are not already Node.js collaborators, they should be approved by the TSC.