lookup: skip native modules that don't build on v12#654
Merged
targos merged 1 commit intonodejs:masterfrom Dec 15, 2018
Merged
Conversation
They're using APIs that were removed from V8.
Codecov Report
@@ Coverage Diff @@
## master #654 +/- ##
=======================================
Coverage 94.41% 94.41%
=======================================
Files 26 26
Lines 823 823
=======================================
Hits 777 777
Misses 46 46Continue to review full report at Codecov.
|
richardlau
approved these changes
Dec 15, 2018
Member
|
Can we open some issues on those modules? |
Member
Author
|
@mcollina Of course we can. Anybody can. Do you want to block this until it's done? |
Member
|
Yes please, those are very popular modules. |
Member
Author
|
Can you please do it? |
Member
|
Sure, I’ll get this done asap (likely Monday). I think it was a common process to open these types of issues when skipping. |
This was referenced Dec 15, 2018
mcollina
approved these changes
Dec 15, 2018
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
LGTM (I've opened the issues).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They're using APIs that were removed from V8.