Skip to content

Conversation

@rvagg
Copy link
Member

@rvagg rvagg commented Apr 5, 2023

I had to reimplement #6 because the changeset was so large, but I managed to do it in a way that preserves commit author.

@rvagg rvagg merged commit 9e87160 into main May 16, 2023
@rvagg rvagg deleted the bengl/green-button branch May 16, 2023 00:02
@github-actions
Copy link

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

rvagg added a commit to nodejs/changelog-maker that referenced this pull request Sep 5, 2023
Ref: nodejs/commit-stream#10

The above change to commit-stream makes it strip out `(#xx)` from the summary
and use it as one of the inputs to find the PR url. The change here just
updates the test assertion to remove that from the commit—we don't need it and
this is an improvement in functionality.
rvagg added a commit to nodejs/changelog-maker that referenced this pull request Sep 6, 2023
Ref: nodejs/commit-stream#10

The above change to commit-stream makes it strip out `(#xx)` from the summary
and use it as one of the inputs to find the PR url. The change here just
updates the test assertion to remove that from the commit—we don't need it and
this is an improvement in functionality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants