*: refactor, format, and update #7
Conversation
|
Pinging @rvagg and @Trott since this repository isn't active. Note: the npm package of this library should also be updated because Snyk caught a vulnerability in the nodejs/node-core-utils that traces back to this library, the npm package of this library hasn't been updated in 6 years. |
rvagg
left a comment
rvagg
left a comment
There was a problem hiding this comment.
seems fine to me, but involving my personal code style preference I wouldn't mind seeing:
- Apply
standardto this, and in particular ditch the semicolons, they're poking my eyes - Single-line
ifs are gross (don't look at my old code pls) and hard to parse, these days I'd much prefer explicit bracing of everyifandelse - Some random blank lines that don't seem to have a pattern, e.g. line 42. I like spacing out code, as long as there's a rhyme to is. Otherwise random blank lines are weird.
Also, thanks for giving it some love!
- Rewrite to ESM. - Refactor the JavaScript files. - Update dependencies and developer dependencies to their latest versions. - Format files with Prettier. - Add `package-lock.json` to `.gitignore`. - Add missing backtick in `README.md`.
| } | ||
| commit.reviewers.push({ name: m[1], email: m[2] }) | ||
| } else if (m = line.match(/^\s+PR(?:[- ]?URL)?:?\s*(.+)\s*$/)) { | ||
| } else if ((m = line.match(/^\s+PR(?:[- ]?URL)?:?\s*(.+)\s*$/)) !== null) { |
There was a problem hiding this comment.
interesting, did standard complain about this or are you just opting to be explicit (not objecting, just intested)
There was a problem hiding this comment.
The standard tool didn't complain about it, I'm just making it explicit.
rvagg
left a comment
rvagg
left a comment
There was a problem hiding this comment.
lgtm, thanks for indulging my preferences!
|
See #8, I've pulled this commit in to there and would like to merge over there than here so we can get an auto-publish flow working. |
|
included in v2.0.0, thanks! https://www.npmjs.com/package/commit-stream/v/2.0.0 |
2 participants
package-lock.jsonto.gitignore.README.md.