Skip to content

Conversation

@avivkeller
Copy link
Member

cc @ovflowd this should fix the scheduling issue, by making the input not required.

Copilot AI review requested due to automatic review settings October 27, 2025 18:12
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a GitHub Actions scheduling issue by removing the required: true constraint from workflow inputs. The change allows scheduled workflows to run without requiring explicit input values, while manual workflow dispatches can still optionally provide them.

Key Changes:

  • Removed required: true from dry_run input parameters in both manual and scheduled workflow files
  • Updated input reference from github.event.inputs.dry_run to inputs.dry_run for proper context handling

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/create-meeting-artifacts-scheduled.yml Removed required constraint from dry_run input and corrected input reference syntax
.github/workflows/create-meeting-artifacts-manual.yml Removed required constraint from dry_run input to allow optional usage

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings October 27, 2025 18:13
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Removed dry_run input from workflow dispatch.
@ovflowd ovflowd merged commit 15e6f57 into nodejs:main Oct 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants