-
-
Notifications
You must be signed in to change notification settings - Fork 43
hotfix: github actions scheduling #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a GitHub Actions scheduling issue by removing the required: true constraint from workflow inputs. The change allows scheduled workflows to run without requiring explicit input values, while manual workflow dispatches can still optionally provide them.
Key Changes:
- Removed
required: truefromdry_runinput parameters in both manual and scheduled workflow files - Updated input reference from
github.event.inputs.dry_runtoinputs.dry_runfor proper context handling
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/create-meeting-artifacts-scheduled.yml |
Removed required constraint from dry_run input and corrected input reference syntax |
.github/workflows/create-meeting-artifacts-manual.yml |
Removed required constraint from dry_run input to allow optional usage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Removed dry_run input from workflow dispatch.
cc @ovflowd this should fix the scheduling issue, by making the input not required.