Skip to content

fix(ci): add type map#738

Merged
avivkeller merged 1 commit intomainfrom
typemap
Apr 1, 2026
Merged

fix(ci): add type map#738
avivkeller merged 1 commit intomainfrom
typemap

Conversation

@avivkeller
Copy link
Copy Markdown
Member

We should use node core's typemap in our CI

Copilot AI review requested due to automatic review settings April 1, 2026 15:10
@avivkeller avivkeller requested a review from a team as a code owner April 1, 2026 15:10
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
api-docs-tooling Ready Ready Preview Apr 1, 2026 3:11pm

Request Review

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.37%. Comparing base (27de0e7) to head (23a7ef6).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #738   +/-   ##
=======================================
  Coverage   76.37%   76.37%           
=======================================
  Files         155      155           
  Lines       13766    13766           
  Branches     1093     1093           
=======================================
  Hits        10514    10514           
  Misses       3247     3247           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the CI/Vercel generation pipeline to use Node core’s doc/type-map.json when running the generator, so type references can be resolved using Node’s upstream type map.

Changes:

  • Expand Node repo sparse checkouts to include doc/ (so doc/type-map.json is available).
  • Pass --type-map ./node/doc/type-map.json to bin/cli.mjs generate in Vercel and GitHub Actions.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
scripts/vercel-prepare.sh Adjusts sparse-checkout paths to include doc/ so the type map file is present.
scripts/vercel-build.sh Adds --type-map argument pointing at Node’s doc/type-map.json.
.github/workflows/generate.yml Updates sparse-checkout to include doc/ and passes --type-map in CI generation runs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM! Feel free to fast-track as a fix once CI passes.

@avivkeller avivkeller added the fast track This PR can land before the typical review time, with a :+1: from collaborators label Apr 1, 2026
@avivkeller avivkeller merged commit 91081a3 into main Apr 1, 2026
25 checks passed
@avivkeller avivkeller deleted the typemap branch April 1, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast track This PR can land before the typical review time, with a :+1: from collaborators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants