Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #738 +/- ##
=======================================
Coverage 76.37% 76.37%
=======================================
Files 155 155
Lines 13766 13766
Branches 1093 1093
=======================================
Hits 10514 10514
Misses 3247 3247
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates the CI/Vercel generation pipeline to use Node core’s doc/type-map.json when running the generator, so type references can be resolved using Node’s upstream type map.
Changes:
- Expand Node repo sparse checkouts to include
doc/(sodoc/type-map.jsonis available). - Pass
--type-map ./node/doc/type-map.jsontobin/cli.mjs generatein Vercel and GitHub Actions.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| scripts/vercel-prepare.sh | Adjusts sparse-checkout paths to include doc/ so the type map file is present. |
| scripts/vercel-build.sh | Adds --type-map argument pointing at Node’s doc/type-map.json. |
| .github/workflows/generate.yml | Updates sparse-checkout to include doc/ and passes --type-map in CI generation runs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ovflowd
left a comment
There was a problem hiding this comment.
SGTM! Feel free to fast-track as a fix once CI passes.
We should use node core's typemap in our CI