fix: disable wasm highlighter for big endian platforms#769
fix: disable wasm highlighter for big endian platforms#769ovflowd merged 2 commits intonodejs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview Bumps the package version from Reviewed by Cursor Bugbot for commit 9d222a1. Bugbot is set up for automated code reviews on this repo. Configure here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #769 +/- ##
=======================================
Coverage 78.43% 78.44%
=======================================
Files 157 157
Lines 13962 13967 +5
Branches 1152 1152
=======================================
+ Hits 10951 10956 +5
Misses 3006 3006
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@nodejs/web-infra I believe this needs to be fast-tracked as hot-fix, @kxxt last favor, could you please bump the version of doc-kit on the package.json? |
|
bump @kxxt |
Done. Sorry about the delay. I was away from my computer for a while. |
Please do not apologize! 🙇 |
Description
In PR fix: disable wasm highlighter on riscv64, as an unrelated change, the wasm highlighter is re-enabled for s390x given the corresponding bug has been fixed. It later broke node.js CI in nodejs/node#62512 because the wasm highlighter is not compatible with big endian platforms like s390x.
Thus disable the wasm highlighter for all big endian platforms until it is fixed.
Validation
Related Issues
Check List
node --run testand all tests passed.node --run format&node --run lint.