Skip to content

Disable make verbose mode in Alpine Dockerflie template#1024

Merged
PeterDaveHello merged 1 commit intonodejs:masterfrom
PeterDaveHello:disable-alpine-make-verbose
Apr 23, 2019
Merged

Disable make verbose mode in Alpine Dockerflie template#1024
PeterDaveHello merged 1 commit intonodejs:masterfrom
PeterDaveHello:disable-alpine-make-verbose

Conversation

@PeterDaveHello
Copy link
Copy Markdown
Member

Missing in #1022

@PeterDaveHello PeterDaveHello requested a review from a team April 23, 2019 17:07
Copy link
Copy Markdown
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, the one we care about 😀

@chorrell
Copy link
Copy Markdown
Contributor

From #1021 (comment)

Put V= in front of the make command

Is this and #1022 actually correct?

@chorrell
Copy link
Copy Markdown
Contributor

Also wouldn't you want to use it for both make commands?

@chorrell
Copy link
Copy Markdown
Contributor

Actually, yeah, make V= is correct. Can also be make VERBOSE= I think.

My other point still stands though, I would add it to the make install command as well

@SimenB
Copy link
Copy Markdown
Member

SimenB commented Apr 23, 2019

@chorrell if you're at a computer, push it? Makes sense to me :)

@chorrell
Copy link
Copy Markdown
Contributor

The thing is...I tested this locally and it doesn't work as far as I can tell -- the make output still seems pretty verbose to me.

@PeterDaveHello PeterDaveHello merged commit d6d93f5 into nodejs:master Apr 23, 2019
@PeterDaveHello PeterDaveHello deleted the disable-alpine-make-verbose branch April 23, 2019 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants