Skip to content

chore: Add 12 to stackbrew generation#1027

Merged
SimenB merged 1 commit intonodejs:masterfrom
nschonni:update-12
Apr 25, 2019
Merged

chore: Add 12 to stackbrew generation#1027
SimenB merged 1 commit intonodejs:masterfrom
nschonni:update-12

Conversation

@nschonni
Copy link
Copy Markdown
Member

@nschonni nschonni commented Apr 25, 2019

No description provided.

Copy link
Copy Markdown
Member

@gengjiawen gengjiawen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

11 is not EOL, see https://github.com/nodejs/Release.

@nschonni nschonni changed the title chore: Replace 11 with 12 stable chore: Add 12 to stackbrew generation Apr 25, 2019
@nschonni
Copy link
Copy Markdown
Member Author

@LaurentGoderre should the auto-pr work for this?

@SimenB SimenB merged commit 4d82413 into nodejs:master Apr 25, 2019
@nschonni nschonni deleted the update-12 branch April 25, 2019 06:34
@SimenB
Copy link
Copy Markdown
Member

SimenB commented Apr 25, 2019

Did not trigger an automatic PR since no dockerfile changed.

docker-library/official-images#5803

@LaurentGoderre
Copy link
Copy Markdown
Member

Should we tackle this edge case for the auto pr or just do those manually?

@SimenB
Copy link
Copy Markdown
Member

SimenB commented Apr 25, 2019

The commits in the chakra images change, otherwise I'd suggest attempting and aborting on no diff against remote

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants