Skip to content

Added alpine 3.13 base distrib for node.js v14 and v15#1426

Merged
nschonni merged 1 commit intonodejs:masterfrom
eko:added-alpine3.13
Feb 12, 2021
Merged

Added alpine 3.13 base distrib for node.js v14 and v15#1426
nschonni merged 1 commit intonodejs:masterfrom
eko:added-alpine3.13

Conversation

@eko
Copy link
Copy Markdown
Contributor

@eko eko commented Jan 17, 2021

Description

Alpine just released its v3.13 version.

Motivation and Context

For more information, see release blog post: https://alpinelinux.org/posts/Alpine-3.13.0-released.html

Testing Details

N/A

Example Output(if appropriate)

N/A

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Others (non of above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

@nschonni nschonni linked an issue Jan 19, 2021 that may be closed by this pull request
@nschonni
Copy link
Copy Markdown
Member

Alpine just released its v3.13 version with some performances improvements in the way on how NodeJS is built.

Not really applicable here since we build Node ourselves and don't use the APK version

@eko
Copy link
Copy Markdown
Contributor Author

eko commented Jan 19, 2021

Hi @nschonni, You're right sorry, so this is not really an argument to upgrade but simply to be based on the latest alpine version ;)

@eko eko force-pushed the added-alpine3.13 branch from 3859ac1 to 43e77c1 Compare January 30, 2021 10:25
@hairyhenderson
Copy link
Copy Markdown

Is there anything blocking this from being merged? There are some CVEs present in the Alpine-3.12 based images that aren't present in 3.13.x, so it'd be great to get this in soon.

@eko
Copy link
Copy Markdown
Contributor Author

eko commented Feb 2, 2021

I think we are good to go, let me know if something else is needed.

@nschonni nschonni mentioned this pull request Feb 10, 2021
@nschonni
Copy link
Copy Markdown
Member

@eko I'm going to see if any of the other maintainers want to chime in by Friday, otherwise I'll ping you to update this for the few version bumps that happened to v14 and v15 since this got opened

@nschonni
Copy link
Copy Markdown
Member

@eko I didn't here any other feedback, so do you want to re-run script to get the latest versions/hashes?

@eko eko force-pushed the added-alpine3.13 branch 2 times, most recently from 3ff8319 to c39961c Compare February 12, 2021 21:32
@eko
Copy link
Copy Markdown
Contributor Author

eko commented Feb 12, 2021

@nschonni Great, thank you, I just executed the script update.sh script

Alpine just released its v3.13 version with some performances
improvements in the way on how NodeJS is built.

For more information, see release blog post: https://alpinelinux.org/posts/Alpine-3.13.0-released.html
@eko eko force-pushed the added-alpine3.13 branch from c39961c to dbee85c Compare February 12, 2021 21:46
Copy link
Copy Markdown
Member

@nschonni nschonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also includes the v10 and v12 bumps from this week, so I'll adjust the message when landing

@nschonni nschonni merged commit 27000ce into nodejs:master Feb 12, 2021
@github-actions
Copy link
Copy Markdown

Created PR on the official-images repo (docker-library/official-images#9628). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Alpine 3.13 support

3 participants