-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: bump Node.js version to 20.20.0, 22.22.0, 24.13.0, 25.3.0 #2344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PeterDaveHello
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v24 for Alpine missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request updates Node.js versions across multiple Docker image variants. The update targets four major Node.js versions: 20.x, 22.x, 24.x, and 25.x, upgrading them to their latest patch releases.
Changes:
- Node.js 20: Updated from 20.19.6 to 20.20.0 across all variants
- Node.js 22: Updated from 22.21.1 to 22.22.0 across all variants
- Node.js 24: Updated from 24.12.0 to 24.13.0 for Debian-based variants only (Alpine variants missing)
- Node.js 25: Updated from 25.2.1 to 25.3.0 across all variants
Reviewed changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| 25/trixie/Dockerfile | Updated NODE_VERSION to 25.3.0 |
| 25/trixie-slim/Dockerfile | Updated NODE_VERSION to 25.3.0 |
| 25/bullseye/Dockerfile | Updated NODE_VERSION to 25.3.0 |
| 25/bullseye-slim/Dockerfile | Updated NODE_VERSION to 25.3.0 |
| 25/bookworm/Dockerfile | Updated NODE_VERSION to 25.3.0 |
| 25/bookworm-slim/Dockerfile | Updated NODE_VERSION to 25.3.0 |
| 25/alpine3.23/Dockerfile | Updated NODE_VERSION to 25.3.0 and x86_64 CHECKSUM |
| 25/alpine3.22/Dockerfile | Updated NODE_VERSION to 25.3.0 and x86_64 CHECKSUM |
| 24/trixie/Dockerfile | Updated NODE_VERSION to 24.13.0 |
| 24/trixie-slim/Dockerfile | Updated NODE_VERSION to 24.13.0 |
| 24/bullseye/Dockerfile | Updated NODE_VERSION to 24.13.0 |
| 24/bullseye-slim/Dockerfile | Updated NODE_VERSION to 24.13.0 |
| 24/bookworm/Dockerfile | Updated NODE_VERSION to 24.13.0 |
| 24/bookworm-slim/Dockerfile | Updated NODE_VERSION to 24.13.0 |
| 22/trixie/Dockerfile | Updated NODE_VERSION to 22.22.0 |
| 22/trixie-slim/Dockerfile | Updated NODE_VERSION to 22.22.0 |
| 22/bullseye/Dockerfile | Updated NODE_VERSION to 22.22.0 |
| 22/bullseye-slim/Dockerfile | Updated NODE_VERSION to 22.22.0 |
| 22/bookworm/Dockerfile | Updated NODE_VERSION to 22.22.0 |
| 22/bookworm-slim/Dockerfile | Updated NODE_VERSION to 22.22.0 |
| 22/alpine3.23/Dockerfile | Updated NODE_VERSION to 22.22.0 and x86_64 CHECKSUM |
| 22/alpine3.22/Dockerfile | Updated NODE_VERSION to 22.22.0 and x86_64 CHECKSUM |
| 20/trixie/Dockerfile | Updated NODE_VERSION to 20.20.0 |
| 20/trixie-slim/Dockerfile | Updated NODE_VERSION to 20.20.0 |
| 20/bullseye/Dockerfile | Updated NODE_VERSION to 20.20.0 |
| 20/bullseye-slim/Dockerfile | Updated NODE_VERSION to 20.20.0 |
| 20/bookworm/Dockerfile | Updated NODE_VERSION to 20.20.0 |
| 20/bookworm-slim/Dockerfile | Updated NODE_VERSION to 20.20.0 |
| 20/alpine3.23/Dockerfile | Updated NODE_VERSION to 20.20.0 and x86_64 CHECKSUM |
| 20/alpine3.22/Dockerfile | Updated NODE_VERSION to 20.20.0 and x86_64 CHECKSUM |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Dear owners, can we approve this? ;) PS: ah oke oke, I see, we need changes in alpine for 24 |
Correct, the update.sh fails on those 2 flavors. Fatal Error: Failed to fetch checksum for version 24.13.0 Don't know how to solve this issue. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to land this. If 24 is ready before upstream Docker merges, the upstream PR will be updated
|
Created PR on the official-images repo (docker-library/official-images#20637). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub. |
Interesting, and apologies if this was out of turn as a triager to close #2340 - it looked like we were counting on the automation to do the work |
|
24.13.0 musl is now completed. Is there some trickery that needs to be done for the automatic MR to be created? Or does it need to be done manually now? |
|
@mdavidsen It's usually automatic, but we're hitting an issue that needs fixing. I've just manually opened #2349 to keep the progress moving here, for your reference. |
Description
Motivation and Context
Testing Details
Example Output(if appropriate)
Types of changes
Checklist