Skip to content

feat: drop Debian 12 bookworm s390x variant#2557

Merged
MikeMcC399 merged 1 commit into
nodejs:mainfrom
MikeMcC399:drop-bookworm-s390x
Jul 7, 2026
Merged

feat: drop Debian 12 bookworm s390x variant#2557
MikeMcC399 merged 1 commit into
nodejs:mainfrom
MikeMcC399:drop-bookworm-s390x

Conversation

@MikeMcC399

Copy link
Copy Markdown
Contributor

Description

  • Remove the s390x variant from bookworm and bookworm-slim configurations in versions.json for each Node.js version.

Motivation and Context

bookworm LTS support status was entered on June 11, 2026 and lasts until June 30, 2028. The supported architectures are reduced to:

i386, amd64, arm64, armhf and ppc64el

Since this does not include s390x any more, this architectural variant must be removed from future bookworm builds.

Testing Details

Check CI actions/workflows/build-test.yml

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (none of the above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

bookworm s390x is no longer supported by Debian since bookworm
transition into LTS support status on 2026-06-11
@MikeMcC399 MikeMcC399 marked this pull request as ready for review July 7, 2026 12:35
@MikeMcC399 MikeMcC399 added debian Debian operating system build process labels Jul 7, 2026
@MikeMcC399 MikeMcC399 requested review from nschonni and sxa July 7, 2026 12:40
@MikeMcC399

MikeMcC399 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

If this PR is approved and merged, then it should automatically create a PR to update https://github.com/docker-library/official-images

I would expect it then to run in the official-images repo and update the tags to remove s390x from the current set of published Docker node images. These were each published after the bookworm LTS transition date on Jun 11, 2026.

Node.js Release date
26.4.0 Jun 24, 2026
24.18.0 Jun 23, 2026
22.33.1 June 23, 2026

so these should not include s390x anyway.

Managing these types of changes seems a little awkward, however I don't know of a better way than to do it like this!

@MikeMcC399

This comment was marked as resolved.

@sxa sxa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ok although we should consider whether we need to make a wider announcement on this somewhere (e.g. in the upcoming releases - FYI @richardlau)

Noting for anyone reading this that it only applies now that Debian 12 (bookworm) is in their LTS phase - the later versions (e.g. Debian 13 "trixie") are unaffected.

@MikeMcC399 MikeMcC399 merged commit ade2ecf into nodejs:main Jul 7, 2026
1 check passed
@MikeMcC399 MikeMcC399 deleted the drop-bookworm-s390x branch July 7, 2026 14:26
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Created PR on the official-images repo (docker-library/official-images#21794). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.

@richardlau

Copy link
Copy Markdown
Member

I think this is ok although we should consider whether we need to make a wider announcement on this somewhere (e.g. in the upcoming releases - FYI @richardlau)

If we do I think it should be its own announcement as it doesn't just affect one release line.

@MikeMcC399

Copy link
Copy Markdown
Contributor Author

I think this is ok although we should consider whether we need to make a wider announcement on this somewhere (e.g. in the upcoming releases - FYI @richardlau)

If we do I think it should be its own announcement as it doesn't just affect one release line.

There doesn't appear to be a precedent for announcing changes to Node.js Docker images. Perhaps the release team would like to decide if the regular Node.js blog should be used for this. If so, it should probably be added as guidance to the CONTRIBUTING document, so that significant updates get their own blog announcement prepared.

This should probably be a separate topic here anyway.

@nschonni

nschonni commented Jul 7, 2026

Copy link
Copy Markdown
Member

I think in the past, we'd usually be lagging, and @tianon, @yosifkit or @LaurentGoderre would create a PR when they'd start removing in from the base images. Looks like that might not have happened yet https://github.com/docker-library/official-images/blob/master/library/debian

@richardlau

Copy link
Copy Markdown
Member

I think this is ok although we should consider whether we need to make a wider announcement on this somewhere (e.g. in the upcoming releases - FYI @richardlau)

If we do I think it should be its own announcement as it doesn't just affect one release line.

There doesn't appear to be a precedent for announcing changes to Node.js Docker images. Perhaps the release team would like to decide if the regular Node.js blog should be used for this. If so, it should probably be added as guidance to the CONTRIBUTING document, so that significant updates get their own blog announcement prepared.

It's not under the responsibilities of the Release team though (it was a responsibility under the Docker WG). Although as announcement channels, the Node.js blog on the website would be the default choice.

This should probably be a separate topic here anyway.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build process debian Debian operating system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adapt to Debian 12 (bookworm) EOL transition to LTS on 2026-06-10

4 participants