Use only major version for directory names #583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
Author
|
Rebased off master and pushed. I think this should be good to merge now. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
Author
|
I'll merge this later tonight if everyone is cool with it. |
PeterDaveHello
added a commit
to PeterDaveHello/official-images
that referenced
this pull request
Nov 15, 2017
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames the Dockerfile directories to only use the Major Node.js version rather than major.minor. This also updates the
update.shandgenerate-stackbrew-library.shscripts to deal with the new directory naming. And finally.travis.ymlwas also updated too -- this change means we no longer need to use the.*wildcardThis should simplify updating the Dockerfiles (via
update.sh) whenever there is a change to the minor version (like going from9.0to9.1). Previously, we would have to manually rename the respective directories and then run theupdate.shscript.