Skip to content

Fix the update script and .travis.yml.template #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 15, 2018
Merged

Fix the update script and .travis.yml.template #732

merged 2 commits into from
May 15, 2018

Conversation

@LaurentGoderre
Copy link
Member

@LaurentGoderre LaurentGoderre commented May 15, 2018

No description provided.

@LaurentGoderre
Copy link
Member Author

LaurentGoderre commented May 15, 2018

My bad @PeterDaveHello I didn't catch that your PR change to .travis.yml weren't reflected in the travis template file.

@LaurentGoderre
Copy link
Member Author

LaurentGoderre commented May 15, 2018

Note that this needs to be merged before any change to the images.

chorrell

This comment was marked as off-topic.

Sign in to view

PeterDaveHello

This comment was marked as off-topic.

Sign in to view

@chorrell
Copy link
Contributor

chorrell commented May 15, 2018

I'm ok with it since the update.sh script generates .travis.yml from travis.yml.template

chorrell

This comment was marked as off-topic.

Sign in to view

PeterDaveHello

This comment was marked as off-topic.

Sign in to view

@PeterDaveHello PeterDaveHello changed the title Fix the update script Fix the update script and .travis.yml.template May 15, 2018
@PeterDaveHello PeterDaveHello merged commit 2835ca0 into nodejs:master May 15, 2018
@LaurentGoderre LaurentGoderre deleted the fix-update branch May 15, 2018 16:22
@PeterDaveHello
Copy link
Member

PeterDaveHello commented May 15, 2018

The update.sh script still generates a diff in .travis.yml, I'd send a PR to test consistency with .travis.yml and the template file and fix the issue.

@PeterDaveHello PeterDaveHello mentioned this pull request May 15, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PeterDaveHello PeterDaveHello PeterDaveHello approved these changes

+2 more reviewers

@mvdan mvdan mvdan left review comments

@chorrell chorrell chorrell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LaurentGoderre @chorrell @PeterDaveHello @mvdan