Skip to content

Conversation

@PeterDaveHello
Copy link
Member

cc #732

@PeterDaveHello PeterDaveHello requested a review from a team May 15, 2018 16:32
chorrell

This comment was marked as off-topic.

@PeterDaveHello PeterDaveHello force-pushed the test-travis-ci-config branch from 41bd65b to c555575 Compare May 15, 2018 16:34
@PeterDaveHello
Copy link
Member Author

Let it fail and I'd push the fix :)

@LaurentGoderre
Copy link
Member

One thing that might trip this is the trailing new line for the editorconfig. The update script might not add it.

@PeterDaveHello
Copy link
Member Author

PeterDaveHello commented May 15, 2018

I'd fix it the newline issue later once it failed, a patch is already ready.

@PeterDaveHello PeterDaveHello force-pushed the test-travis-ci-config branch from c555575 to f08f798 Compare May 15, 2018 16:44
@PeterDaveHello PeterDaveHello requested a review from a team May 15, 2018 18:55
chorrell

This comment was marked as off-topic.

@PeterDaveHello PeterDaveHello merged commit 1e68152 into master May 16, 2018
@PeterDaveHello PeterDaveHello deleted the test-travis-ci-config branch May 16, 2018 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants