Merged
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Member
Author
|
PS: @LaurentGoderre this didn't trigger a official-images PR |
Member
|
It wouldn't since the version no longer appears as a valid version. I guess it's a limitation of the detection we use currently |
Member
Author
|
Actually, I guess it doesn't matter since it just means the diff will get calculated next time there is actually a functional change. The PR would really just update to the file in official images to drop the 9, but the other hashes would be the same. |
PeterDaveHello
added a commit
to PeterDaveHello/official-images
that referenced
this pull request
Jul 18, 2018
- Update node.js v10.x to v10.7.0 - For Alpine based image, update Alpine from v3.7 to v3.8 Node.js v10.7.0 ref: - nodejs/docker-node#820 - https://github.com/nodejs/node/releases/tag/v10.7.0 - https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V10.md#10.7.0 Node.js v9 ref: - nodejs/docker-node#803 - docker-library#4536
LaurentGoderre
pushed a commit
to LaurentGoderre/docker-node
that referenced
this pull request
Nov 18, 2018
Support for 9 dropped yesterday https://github.com/nodejs/Release/blob/bc9d936e153b9fafd7f7c203f139d02035ca6862/schedule.json#L44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for 9 dropped yesterday https://github.com/nodejs/Release/blob/bc9d936e153b9fafd7f7c203f139d02035ca6862/schedule.json#L44