Skip to content

Update node.js v10.x to v10.6.0#807

Merged
PeterDaveHello merged 1 commit intomasterfrom
update-node.js
Jul 4, 2018
Merged

Update node.js v10.x to v10.6.0#807
PeterDaveHello merged 1 commit intomasterfrom
update-node.js

Conversation

@PeterDaveHello
Copy link
Copy Markdown
Member

@PeterDaveHello PeterDaveHello requested a review from a team July 4, 2018 18:28
LaurentGoderre

This comment was marked as off-topic.

@PeterDaveHello
Copy link
Copy Markdown
Member Author

I canceled the branch build, there is no need to run all the same tests twice, and should send the pull request from my forked repo to prevent that.

@PeterDaveHello
Copy link
Copy Markdown
Member Author

Also canceled unrelated builds for non-10 versions. Save time and resources.

@LaurentGoderre
Copy link
Copy Markdown
Member

Should we avoid using this repo for PR branches to avoid double builds?

@PeterDaveHello
Copy link
Copy Markdown
Member Author

Yes, I believe so, unless those with [ci skip]

@PeterDaveHello
Copy link
Copy Markdown
Member Author

@LaurentGoderre
Copy link
Copy Markdown
Member

The bot doesn't work anymore?

@LaurentGoderre
Copy link
Copy Markdown
Member

The change detection seems broken :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants