Skip to content

Update chakracore v10 to v10.6.0#824

Merged
SimenB merged 1 commit intonodejs:masterfrom
PeterDaveHello:update-node.js
Jul 21, 2018
Merged

Update chakracore v10 to v10.6.0#824
SimenB merged 1 commit intonodejs:masterfrom
PeterDaveHello:update-node.js

Conversation

@PeterDaveHello
Copy link
Copy Markdown
Member

kfarnung

This comment was marked as off-topic.

@LaurentGoderre
Copy link
Copy Markdown
Member

Would there be a point to creating the intermediate versions?

@SimenB
Copy link
Copy Markdown
Member

SimenB commented Jul 21, 2018

@LaurentGoderre they don't have the same releases: https://github.com/nodejs/node-chakracore/releases

SimenB

This comment was marked as off-topic.

@SimenB SimenB merged commit ea61a26 into nodejs:master Jul 21, 2018
@PeterDaveHello PeterDaveHello deleted the update-node.js branch July 21, 2018 06:11
@PeterDaveHello
Copy link
Copy Markdown
Member Author

@SimenB will you send PR to official-images for this one or let me do it?

@SimenB
Copy link
Copy Markdown
Member

SimenB commented Jul 21, 2018

I'll try to let the bot open up a PR

@SimenB
Copy link
Copy Markdown
Member

SimenB commented Jul 21, 2018

image

:(

@SimenB
Copy link
Copy Markdown
Member

SimenB commented Jul 21, 2018

@PeterDaveHello
Copy link
Copy Markdown
Member Author

I think it's broken for a while.

@SimenB
Copy link
Copy Markdown
Member

SimenB commented Jul 21, 2018

The build had a network failure for alpine, nothing to do with the update script

@nschonni
Copy link
Copy Markdown
Member

Yeah, saw the same in #805 even though the update script is removed

@LaurentGoderre
Copy link
Copy Markdown
Member

The update script is working but it has problems detecting changes. I need to look into it.

@LaurentGoderre
Copy link
Copy Markdown
Member

@SimenB we can restart build steps now!

@nschonni
Copy link
Copy Markdown
Member

@LaurentGoderre maybe something like this branch compare would work https://stackoverflow.com/a/822859/455535 instead of the COMMIT_ID

@LaurentGoderre
Copy link
Copy Markdown
Member

We can't use that because we are not always using branches. In fact most of the time we shouldn't use local branches. We need to use the commit range which seems buggy with Travis.

LaurentGoderre pushed a commit to LaurentGoderre/docker-node that referenced this pull request Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants