Mention our Docker team in auto PR body as notification#976
Merged
PeterDaveHello merged 3 commits intonodejs:masterfrom Jan 25, 2019
Merged
Mention our Docker team in auto PR body as notification#976PeterDaveHello merged 3 commits intonodejs:masterfrom
PeterDaveHello merged 3 commits intonodejs:masterfrom
Conversation
PeterDaveHello
force-pushed
the
update-auto-PR-comment
branch
from
3bf6839 to
ba22c13
Compare
SimenB
previously requested changes
Jan 19, 2019
Member
SimenB
left a comment
SimenB
left a comment
There was a problem hiding this comment.
The tag doesn't work in the docker repo (I just tried it). Should we enumerate them?
Member
Author
|
Which tag? Is it related to this PR? |
Member
|
hah, dumb typo |
Member
Author
|
@nodejs/docker no? |
Member
Author
|
Okay, I got your point - out side the org. |
Member
Author
|
What about to maintain an active member list of our docker team? As tag them all? cc @nodejs/docker |
Member
|
That works for me 🙂 |
PeterDaveHello
force-pushed
the
update-auto-PR-comment
branch
from
e1ea66b to
738e904
Compare
Member
Author
|
Updated. |
LaurentGoderre
approved these changes
Jan 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It'll be great to know that in the notification as not everyone will involve in origin PR.