Update config for Alpine 3.9#988
Merged
PeterDaveHello merged 1 commit intonodejs:masterfrom Jan 31, 2019
chorrell:alpine-3.9
Merged
Update config for Alpine 3.9#988PeterDaveHello merged 1 commit intonodejs:masterfrom chorrell:alpine-3.9
PeterDaveHello merged 1 commit intonodejs:masterfrom
chorrell:alpine-3.9
Conversation
Member
|
I would vote for next version personally. |
Contributor
Author
|
Should I just update the |
Member
|
Sounds better 👍 |
Member
|
@chorrell you can just update this PR instead of opening a new one |
Contributor
Author
|
I updated my PR to just update the |
LaurentGoderre
approved these changes
Jan 31, 2019
PeterDaveHello
approved these changes
Jan 31, 2019
|
Not sure if I am missing something, but the dockerfile still uses 3.8 🤔 https://github.com/nodejs/docker-node/blob/master/11/alpine/Dockerfile |
Member
|
New version not released yet. |
PeterDaveHello
added a commit
to PeterDaveHello/docker-node
that referenced
this pull request
Feb 15, 2019
PeterDaveHello
added a commit
to PeterDaveHello/docker-node
that referenced
this pull request
Feb 15, 2019
|
Do we know when will it be officially released? Looking for node:8-alpine with alpine 3.9. |
Member
|
@MylesBorins do you know if a version 8 update is planned soon? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update for Alpine 3.9:
Closes #987
Do we want a DockerHub PR for this or should we include it with the next Node.js updates? I think we decided that we'd err on the side of keeping Alpine current.