Skip to content

Add Community Committee list#46

Merged
MylesBorins merged 1 commit intonodejs:masterfrom
hackygolucky:patch-1
Aug 15, 2017
Merged

Add Community Committee list#46
MylesBorins merged 1 commit intonodejs:masterfrom
hackygolucky:patch-1

Conversation

@hackygolucky
Copy link
Copy Markdown
Contributor

Only those who said they were okay with publish in the repo issue are listed.

Only those who said they were okay with publish in the repo issue are listed
bnb

This comment was marked as off-topic.

@MylesBorins
Copy link
Copy Markdown
Contributor

It looks like some emails are missing from that list

@nodejs/tsc @nodejs/build do we need to do anything more than this to add an alias?

mhdawson

This comment was marked as off-topic.

@mhdawson
Copy link
Copy Markdown
Member

@MylesBorins I'm not 100% sure but I think this is all we need. I'd suggest we land/test to make sure.

@MylesBorins MylesBorins merged commit c117ad5 into nodejs:master Aug 15, 2017
@MylesBorins
Copy link
Copy Markdown
Contributor

landed + sent out test email

@MylesBorins
Copy link
Copy Markdown
Contributor

oh no
screen shot 2017-08-15 at 4 09 05 pm

@mhdawson
Copy link
Copy Markdown
Member

Lets make sure other addresses are not messed up in case we need to revert.

@mhdawson
Copy link
Copy Markdown
Member

ok email to a different list that I'm on worked ok so at least the others are still ok. So now to figure out what else needs to happen to enable the list.

@mhdawson
Copy link
Copy Markdown
Member

@jbergstroem, @rvagg what else do we need to do to get the alias enabled ?

@rvagg
Copy link
Copy Markdown
Member

rvagg commented Aug 16, 2017

@mhdawson can I assume from your test email to build@ that you figured out how to get it working yourself?

@mhdawson
Copy link
Copy Markdown
Member

@rvagg no, just that we had not broken the others.

The question we have is whether anything other than making this change should be necessary or not. If the answer is yes, then what so we can do that. If the answer is no, then we can look closer at the json added to try to figure out why its not working.

@rvagg
Copy link
Copy Markdown
Member

rvagg commented Aug 20, 2017

@mhdawson added more instructions in #47. Let me know if that makes sense and if you can get it to work with that. Should be a straightforward update from then on, credentials.json is in .gitignore so you can just keep your local copy in place.

@mhdawson
Copy link
Copy Markdown
Member

Thanks will follow those instructions and add approval to PR if all goes well.

@mhdawson
Copy link
Copy Markdown
Member

Followed instructions and sent out test email. Will see if it goes through now.

@mhdawson
Copy link
Copy Markdown
Member

mhdawson commented Sep 5, 2017

Seems like it was good once update was run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants