This repository was archived by the owner on Jul 6, 2018. It is now read-only.
http2: allow specifying servername in options#127
Closed
jmuk wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Member
|
One thing to think about.. is there anything we need to do on the server side to make using SNI easier? (I honestly don't know) |
Contributor
Author
|
I actually don't know about the server-side SNI parameter, but it looks like to allow customizing the hostname through |
jasnell
pushed a commit
that referenced
this pull request
May 17, 2017
PR-URL: #127 Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed |
jasnell
pushed a commit
that referenced
this pull request
May 19, 2017
PR-URL: #127 Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
May 31, 2017
PR-URL: #127 Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
to jasnell/http2-1
that referenced
this pull request
Jun 22, 2017
PR-URL: nodejs#127 Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
to jasnell/http2-1
that referenced
this pull request
Jul 10, 2017
PR-URL: nodejs#127 Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
to jasnell/http2-1
that referenced
this pull request
Jul 14, 2017
PR-URL: nodejs#127 Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed that it always use the host name for the SNI parameter, but I think it's better to allow customizing through the options.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http2