This repository was archived by the owner on Jul 6, 2018. It is now read-only.
http2: fix http2-server-startup#149
Closed
jasnell wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
9b6b067 broke the test
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Member
Author
|
Landed! (and no worries @sebdeckers! :-) ...) |
jasnell
added a commit
to jasnell/http2-1
that referenced
this pull request
Jun 22, 2017
9b6b067 broke the test PR-URL: nodejs#149 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Sebastiaan Deckers <sebdeckers83@gmail.com>
jasnell
added a commit
to jasnell/http2-1
that referenced
this pull request
Jul 10, 2017
9b6b067 broke the test PR-URL: nodejs#149 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Sebastiaan Deckers <sebdeckers83@gmail.com>
jasnell
added a commit
to jasnell/http2-1
that referenced
this pull request
Jul 14, 2017
9b6b067 broke the test PR-URL: nodejs#149 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Sebastiaan Deckers <sebdeckers83@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
9b6b067 broke the test... this fixes it
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)