This repository was archived by the owner on Jul 6, 2018. It is now read-only.
src: to ToChecked to holder->SetPrototype#89
Closed
danbev wants to merge 1 commit intonodejs:masterfrom
danbev:check-holder-setprototype
Closed
src: to ToChecked to holder->SetPrototype#89danbev wants to merge 1 commit intonodejs:masterfrom danbev:check-holder-setprototype
danbev wants to merge 1 commit intonodejs:masterfrom
danbev:check-holder-setprototype
Conversation
Currently the following compiler warning is displayed:
/out/Debug/obj.target/node/src/node_http2.o
../src/node_http2.cc
../src/node_http2.cc:../src/node_http2.cc838::8383::3 : warning:
warning: ignoring return value of function declared with
warn_unused_result ignoringattribute return[-Wunused-result]
value
of function declared with
warn_unused_result attribute [-Wunused-result]
holder->SetPrototype(context, v8::Null(isolate));
^~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
This commit adds a check to avoid this warning.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Member
|
Landed! |
jasnell
pushed a commit
that referenced
this pull request
May 7, 2017
Currently the following compiler warning is displayed:
/out/Debug/obj.target/node/src/node_http2.o
../src/node_http2.cc
../src/node_http2.cc:../src/node_http2.cc838::8383::3 : warning:
warning: ignoring return value of function declared with
warn_unused_result ignoringattribute return[-Wunused-result]
value
of function declared with
warn_unused_result attribute [-Wunused-result]
holder->SetPrototype(context, v8::Null(isolate));
^~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
This commit adds a check to avoid this warning.
PR-URL: #89
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
May 19, 2017
Currently the following compiler warning is displayed:
/out/Debug/obj.target/node/src/node_http2.o
../src/node_http2.cc
../src/node_http2.cc:../src/node_http2.cc838::8383::3 : warning:
warning: ignoring return value of function declared with
warn_unused_result ignoringattribute return[-Wunused-result]
value
of function declared with
warn_unused_result attribute [-Wunused-result]
holder->SetPrototype(context, v8::Null(isolate));
^~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
This commit adds a check to avoid this warning.
PR-URL: #89
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
May 31, 2017
Currently the following compiler warning is displayed:
/out/Debug/obj.target/node/src/node_http2.o
../src/node_http2.cc
../src/node_http2.cc:../src/node_http2.cc838::8383::3 : warning:
warning: ignoring return value of function declared with
warn_unused_result ignoringattribute return[-Wunused-result]
value
of function declared with
warn_unused_result attribute [-Wunused-result]
holder->SetPrototype(context, v8::Null(isolate));
^~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
This commit adds a check to avoid this warning.
PR-URL: #89
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
to jasnell/http2-1
that referenced
this pull request
Jun 22, 2017
Currently the following compiler warning is displayed:
/out/Debug/obj.target/node/src/node_http2.o
../src/node_http2.cc
../src/node_http2.cc:../src/node_http2.cc838::8383::3 : warning:
warning: ignoring return value of function declared with
warn_unused_result ignoringattribute return[-Wunused-result]
value
of function declared with
warn_unused_result attribute [-Wunused-result]
holder->SetPrototype(context, v8::Null(isolate));
^~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
This commit adds a check to avoid this warning.
PR-URL: nodejs#89
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
to jasnell/http2-1
that referenced
this pull request
Jul 10, 2017
Currently the following compiler warning is displayed:
/out/Debug/obj.target/node/src/node_http2.o
../src/node_http2.cc
../src/node_http2.cc:../src/node_http2.cc838::8383::3 : warning:
warning: ignoring return value of function declared with
warn_unused_result ignoringattribute return[-Wunused-result]
value
of function declared with
warn_unused_result attribute [-Wunused-result]
holder->SetPrototype(context, v8::Null(isolate));
^~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
This commit adds a check to avoid this warning.
PR-URL: nodejs#89
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
to jasnell/http2-1
that referenced
this pull request
Jul 14, 2017
Currently the following compiler warning is displayed:
/out/Debug/obj.target/node/src/node_http2.o
../src/node_http2.cc
../src/node_http2.cc:../src/node_http2.cc838::8383::3 : warning:
warning: ignoring return value of function declared with
warn_unused_result ignoringattribute return[-Wunused-result]
value
of function declared with
warn_unused_result attribute [-Wunused-result]
holder->SetPrototype(context, v8::Null(isolate));
^~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
This commit adds a check to avoid this warning.
PR-URL: nodejs#89
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the following compiler warning is displayed:
This commit adds a check to avoid this warning.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src