This repository was archived by the owner on Jul 6, 2018. It is now read-only.
src: remove unused MIN/MAX macros#93
Closed
danbev wants to merge 1 commit intonodejs:masterfrom
danbev:remove-unused-macros
Closed
src: remove unused MIN/MAX macros#93danbev wants to merge 1 commit intonodejs:masterfrom danbev:remove-unused-macros
danbev wants to merge 1 commit intonodejs:masterfrom
danbev:remove-unused-macros
Conversation
I cannot find any usage of these macros and it build and all tests pass locally without them.
Member
|
+1 .. yeah, they were left over artifacts. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
jasnell
pushed a commit
that referenced
this pull request
May 8, 2017
I cannot find any usage of these macros and it build and all tests pass locally without them. PR-URL: #93 Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed! |
jasnell
pushed a commit
that referenced
this pull request
May 19, 2017
I cannot find any usage of these macros and it build and all tests pass locally without them. PR-URL: #93 Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
May 31, 2017
I cannot find any usage of these macros and it build and all tests pass locally without them. PR-URL: #93 Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
to jasnell/http2-1
that referenced
this pull request
Jun 22, 2017
I cannot find any usage of these macros and it build and all tests pass locally without them. PR-URL: nodejs#93 Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
to jasnell/http2-1
that referenced
this pull request
Jul 10, 2017
I cannot find any usage of these macros and it build and all tests pass locally without them. PR-URL: nodejs#93 Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
to jasnell/http2-1
that referenced
this pull request
Jul 14, 2017
I cannot find any usage of these macros and it build and all tests pass locally without them. PR-URL: nodejs#93 Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I cannot find any usage of these macros and it build and all tests pass
locally without them.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src