Skip to content

fix(index): use our version#89

Merged
bmuenzenmeyer merged 1 commit into
mainfrom
avivkeller-patch-1
Jun 5, 2026
Merged

fix(index): use our version#89
bmuenzenmeyer merged 1 commit into
mainfrom
avivkeller-patch-1

Conversation

@avivkeller
Copy link
Copy Markdown
Member

Fixes #88

@avivkeller avivkeller requested a review from a team as a code owner June 5, 2026 02:16
Copilot AI review requested due to automatic review settings June 5, 2026 02:16
@cursor
Copy link
Copy Markdown

cursor Bot commented Jun 5, 2026

PR Summary

Low Risk
Single build-config flag with no auth, data, or runtime logic changes.

Overview
Disables doc-kit’s automatic index page generation by adding a jsx-ast block in doc-kit.config.mjs with generateIndexPage: false, so the published site uses the repo’s own index instead of the toolkit default (addresses the learn index issue).

Reviewed by Cursor Bugbot for commit 670de0c. Bugbot is set up for automated code reviews on this repo. Configure here.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-learn Ready Ready Preview Jun 5, 2026 2:16am

Request Review

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 5, 2026

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website

Please review the changes when you have a chance. Thank you! 🙏

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Doc Kit build configuration to stop generating a synthetic index.html via the jsx-ast generator, so the Learn site’s homepage can be driven by the repository’s own content rather than an auto-generated (and currently empty) index page.

Changes:

  • Disable Doc Kit’s jsx-ast synthetic index page generation (generateIndexPage: false).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-tracking - obviously broken

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Jun 5, 2026
Merged via the queue into main with commit 2b4b736 Jun 5, 2026
9 checks passed
@bmuenzenmeyer bmuenzenmeyer deleted the avivkeller-patch-1 branch June 5, 2026 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Learn homepage is oddly empty

3 participants