Skip to content

Add HTTP statuses #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2022
Merged

Add HTTP statuses #179

merged 1 commit into from
Aug 26, 2022

Conversation

@ShogunPanda
Copy link
Contributor

@ShogunPanda ShogunPanda commented Aug 23, 2022 •
edited
Loading

Fixes #106.

@ShogunPanda ShogunPanda changed the title Http statuses Add HTTP statuses Aug 23, 2022
mcollina
mcollina approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

mcollina commented Aug 23, 2022

This might need docs

@ShogunPanda
Copy link
Contributor Author

ShogunPanda commented Aug 26, 2022

@mcollina How would you add docs to this? There is no actual documentation at all here on how to use the API beside the WASM example.

@mcollina
Copy link
Member

mcollina commented Aug 26, 2022

no worries!

@ShogunPanda ShogunPanda merged commit fdc5e1c into nodejs:main Aug 26, 2022
@ShogunPanda ShogunPanda deleted the http-statuses branch August 26, 2022 10:11
@tniessen tniessen mentioned this pull request Oct 1, 2022
Merged
@ShogunPanda ShogunPanda mentioned this pull request Oct 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@indutny indutny Awaiting requested review from indutny

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

http_status

2 participants

@ShogunPanda @mcollina