Show a limited number of entries #235
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Drieger
force-pushed
the
limit_result_of_findjsinstances
branch
2 times, most recently
from
3debe6a to
632afda
Compare
As the number of instances might grow large in some applications, give the user an option to limit the number of entries displayed on command output. Next entries will be displayes when the same command is used or just by pressing [ENTER], this will repeat last command. Refs: nodejs#230
Drieger
force-pushed
the
limit_result_of_findjsinstances
branch
from
632afda to
4f84969
Compare
mmarchini
approved these changes
Oct 5, 2018
Contributor
mmarchini
left a comment
mmarchini
left a comment
There was a problem hiding this comment.
There are a few nits left (include , extra spaces, etc.), but I'll fix those while landing. Thanks!
mmarchini
pushed a commit
that referenced
this pull request
Oct 5, 2018
As the number of instances might grow large in some applications, give the user an option to limit the number of entries displayed on command output. Next entries will be displayes when the same command is used or just by pressing [ENTER], this will repeat last command. Refs: #230 PR-URL: #235 Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Contributor
|
Landed in 2fc1571. Thank you! |
hyj1991
pushed a commit
to aliyun-node/llnode
that referenced
this pull request
Oct 11, 2018
As the number of instances might grow large in some applications, give the user an option to limit the number of entries displayed on command output. Next entries will be displayes when the same command is used or just by pressing [ENTER], this will repeat last command. Refs: nodejs#230 PR-URL: nodejs#235 Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new option to
findjsinstancesthat allow user to limit the number of entries shown. Command would be as followFirst
numentries will be displayed, to see the followingnuminstances user would just repeat the samenumandsearch, or just press [ENTER] as it repeats the last command. Once we reached the last "page" it begins to show from the first entry again.I created a simple example to show usage:
https://asciinema.org/a/X04QMdeyWlDY1DBWeCDBNVUry