implement bit shift node#197
Open
Vizonex wants to merge 2 commits into
Open
Conversation
This was referenced May 26, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I read the old pull request from 6 years ago that attempted to implement integer packing and with my desire to write a new socks5 parser soon that parses negotiation packets on both the client and server's end as part of RFC1928 I knew that doing so would not be an easy task. Currently It requires some functionality that llparse currently doesn't implement. My goal here is to change that entirely as I understand llparse's code architecture pretty well as I have made a python parody of this library already.
Goals with this Pull Request
To revive the llparse typescript library as a whole as well as add a few new features to it so that llparse can continue receiving maintenance.
Provide a new node that is small and be easy to maintain
Have actual tests provided to increase the likelihood of these features being added in.
A tool which I named
ShiftCheckernamed after theLoopCheckeris also provided toShiftnodes for missing fieldsptrtype.This solution provides the ability to pack bytes and it simplifies @arthurschreiber's original work and makes the implementation smaller.
The reason I would like for a llsocks5 library to use typescript however is because more people know how to use llparse in the typescript language which means I could be possibly given outside help as well as better feedback which is why I am doing this all to begin with. I might also look into making an smtp parser even though my understanding of the smtp protocol isn't as good as my understanding with the socks5 protocol is which is why I am working on a new socks5 parser first.
closes #1