fix: handle reallocation failure gracefully in DataPointer::resize()#37
Merged
jasnell merged 1 commit intonodejs:mainfrom Mar 23, 2026
Merged
fix: handle reallocation failure gracefully in DataPointer::resize()#37jasnell merged 1 commit intonodejs:mainfrom
jasnell merged 1 commit intonodejs:mainfrom
Conversation
Immediate reassignment leaves the `buf.data` pointer with a nullptr, leaking the original data. Furthermore, it leaves the length field inconsistent. This patch first checks whether the pointer was a nullptr before reassigning.
jasnell
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Immediate reassignment leaves the
buf.datapointer with a nullptr, leaking the original data. Furthermore, it leaves the length field inconsistent.This patch first checks whether the pointer was a nullptr before reassigning.
Note: this was found by a static-dynamic analyser I'm developing.
I plan on sending a corresponding patch to Node itself after acceptance to handle call sites gracefully. Some places already do handle nulls correctly and don't cause a crash on a failed reallocation, but I'd have to double check.