fix: allow const vectors with Object::New overload utilizing node_api_create_object_with_properties - #1755
Merged
legendecas merged 1 commit intoSep 2, 2026
Conversation
Contributor
Author
|
Tested locally against nodejs/node#65621 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1755 +/- ##
=======================================
Coverage 63.68% 63.68%
=======================================
Files 3 3
Lines 2065 2065
Branches 731 731
=======================================
Hits 1315 1315
Misses 162 162
Partials 588 588 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
KevinEady
marked this pull request as ready for review
August 28, 2026 18:17
legendecas
reviewed
Aug 28, 2026
| propertyValues.data(), | ||
| propertyNames.size(), | ||
| &value); | ||
| napi_status status = node_api_create_object_with_properties( |
Member
There was a problem hiding this comment.
Could we add a TODO to remove the const_cast when nodejs/node#65621 is fully backported?
Contributor
Author
…_create_object_with_properties
KevinEady
force-pushed
the
use-const-cast-with-node_api_create_object_with_properties
branch
from
August 31, 2026 18:29
cefce1a to
12be15f
Compare
legendecas
approved these changes
Aug 31, 2026
Member
There was a problem hiding this comment.
Thanks! Let's wait a bit until nodejs/node#65621 lands.
github-project-automation
Bot
moved this from Need Triage
to Done
in Node-API Team Project
legendecas
deleted the
use-const-cast-with-node_api_create_object_with_properties
branch
September 2, 2026 14:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
const_castto removeconst-qualifier from the pointer returned by thevectors'data()method.