Skip to content

ci: update Node.js versions in tests #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2025
+12 −3
Merged

ci: update Node.js versions in tests #1686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b878191
ci: update Node.js versions in tests
KevinEady Oct 26, 2025
ab26829
chore: add define to skip experimental warning
KevinEady Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .github/workflows/ci-win.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,21 @@ jobs:
- standard
- experimental
node-version:
- 18.x
- 20.x
- 22.x
- 24.x
- 25.x
architecture: [x64, x86]
os:
- windows-2022
- windows-2025
exclude:
# Skip when node 24.x or 25.x AND architecture is x86 since there is
# no published Node.js x86 build for those versions.
- node-version: 24.x
architecture: x86
- node-version: 25.x
architecture: x86
runs-on: ${{ matrix.os }}
steps:
- name: Harden Runner
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,10 @@ jobs:
- standard
- experimental
node-version:
- 18.x
- 20.x
- 22.x
- 24.x
- 25.x
os:
- macos-latest
- ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
},
'conditions': [
['NAPI_VERSION!=""', { 'defines': ['NAPI_VERSION=<@(NAPI_VERSION)'] } ],
['NAPI_VERSION==2147483647', { 'defines': ['NAPI_EXPERIMENTAL'] } ],
['NAPI_VERSION==2147483647', { 'defines': ['NAPI_EXPERIMENTAL', 'NODE_API_EXPERIMENTAL_NO_WARNING'] } ],
['disable_deprecated=="true"', {
'defines': ['NODE_ADDON_API_DISABLE_DEPRECATED']
}],
Expand Down