feat: port 6_object_wrap test to CTS#32
Draft
kraenhansen wants to merge 2 commits intonodejs:mainfrom
Draft
Conversation
Vendor Node-API headers from the Node.js repository (replacing the node-api-headers npm package) and introduce infrastructure for experimental feature support. - Vendor headers from Node.js src/ into include/, including experimental API declarations behind #ifdef NAPI_EXPERIMENTAL - Add scripts/update-headers.mjs to download headers and generate layered .def files via clang AST dump - Add add_node_api_cts_experimental_addon() CMake function that defines NAPI_EXPERIMENTAL for addons using experimental APIs - Add implementor feature declaration (features.js) with globalThis.experimentalFeatures for conditional test execution - Add harness test validating the experimentalFeatures global, ensuring every expected feature is declared as a boolean The .def files are deduplicated layers: js_native_api.def contains stable engine-agnostic symbols, node_api.def adds stable runtime symbols, and the _experimental variants add only experimental symbols. CMake combines the layers when generating MSVC import libraries. Closes nodejs#26
Port all three build targets and test files from upstream: - myobject (stable) — object wrap with getters/setters/methods - myobject_basic_finalizer (experimental) — basic finalizer verification - nested_wrap (NAPI_VERSION=10) — nested ref finalization The experimental target (myobject_basic_finalizer) exercises the add_node_api_cts_experimental_addon() CMake function for the first time, serving as end-to-end validation of the experimental infrastructure. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
Drafting until #31 merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Note
Depends on #31 (stacked — includes that commit as the base) - review that first.
Ports the
6_object_wraptest suite from Node.js into the CTS. This is the first test to exercise the experimental addon infrastructure (add_node_api_cts_experimental_addon()), serving as end-to-end validation of #31.Upstream source: https://github.com/nodejs/node/tree/main/test/js-native-api/6_object_wrap
Three build targets:
myobject(stable) — object wrap with getters/setters,plusOne,multiplymyobject_basic_finalizer(experimental,NAPI_EXPERIMENTAL) — basic finalizer verification, guarded byexperimentalFeatures.postFinalizernested_wrap(NAPI_VERSION=10) — nested napi_ref finalizationThree JS test files:
test.js— property descriptors, constructor/plain-function invocation, method chainingtest-basic-finalizer.js— experimental finalizer withgcUntil, behind feature guardnested_wrap.js— nested wrap finalization withgcUntilAll C++ source files are copied verbatim from upstream.
Test plan
npm run addons:configure && npm run addons:build— all three targets compilenpm run node:test— all 30 tests pass (3 new)🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com